feat: [OCISDEV-900] Connect storageprovider with coordinator instead of driver - #721
Open
LarsJurgensen wants to merge 9 commits into
Open
LarsJurgensen wants to merge 9 commits into
LarsJurgensen wants to merge 9 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LarsJurgensen
force-pushed
the
OCISDEV-900-pr7-switchover
branch
from
August 19, 2026 14:12
b1626ed to
6b608d1
Compare
LarsJurgensen
marked this pull request as ready for review
August 20, 2026 14:13
LukasHirt
requested changes
Aug 20, 2026
LukasHirt
left a comment
There was a problem hiding this comment.
Two correctness regressions, one reachability concern, two cleanups.
Blocking:
TouchFile's create-only symlink leaks an orphaned node on a concurrent-create race (pkg/storage/utils/decomposedfs/tree/tree.go:175).OC-FileIdis now permanently omitted from TUS responses for newly-created files (pkg/rhttp/datatx/manager/tus/tus.go:216).
Worth a look:
3. This PR is what makes pkg/upload's postprocessing path live for the dataprovider — and that path has no guard against a node vanishing mid-postprocessing (internal/http/services/dataprovider/dataprovider.go:117).
Minor:
4. Doubled NATS subscriptions for combined decomposedfs+dataprovider deployments (same line).
5. getCoordinator duplicated near-verbatim with storageprovider.go:234 (internal/http/services/dataprovider/dataprovider.go:146).
LarsJurgensen
force-pushed
the
OCISDEV-900-pr7-switchover
branch
from
September 9, 2026 14:31
79bb052 to
4717d97
Compare
LarsJurgensen
force-pushed
the
OCISDEV-900-pr7-switchover
branch
from
September 16, 2026 11:55
4717d97 to
d8ba908
Compare
LukasHirt
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire storageprovider and dataprovider to the upload coordinator. This is the final step that makes TUS, postprocessing, AV scanning, and session management driver-independent.
storageprovider.InitiateFileUploadroutes throughcoord.InitiateUploadinstead offs.InitiateUploaddatatx.DataTX.Handlergains acoordargument alongside the driver; all three implementations (simple, spaces, tus) updatedcoord.Upload; TUS registerscoord.UseIninstead of the driver'sUseInComposableFScheck in the TUS manager removed; the coordinator satisfies the tusd data store interface for every driverPostprocessingFinished,PostprocessingStepFinished,RestartPostprocessing,CleanUpload; the coordinator owns thoseRevertRevisionunder a separate consumer group (<group>-revisions) so it gets its own copy without contending with the coordinator's groupupload_directoryconfig key; required for drivers with no local filesystem root