[mcast, on] default multicast feature across all crates - #361
Open
zeeshanlakhani wants to merge 1 commit into
Open
[mcast, on] default multicast feature across all crates#361zeeshanlakhani wants to merge 1 commit into
zeeshanlakhani wants to merge 1 commit into
Conversation
zeeshanlakhani
force-pushed
the
zl/mcast-default-feature
branch
from
September 1, 2026 07:47
4fa1b5b to
27fdfaf
Compare
zeeshanlakhani
requested review from
FelixMcFelix,
cfzimmerman and
taspelund
September 6, 2026 04:55
This enables the multicast feature on by default across crates and adds `--no-multicast` to exclude mcast from the shipped P4 codegen build. With the feature on by default, the packet test harness no longer needs its MULTICAST conditional or any redundant setup.
zeeshanlakhani
force-pushed
the
zl/mcast-default-feature
branch
from
September 8, 2026 03:29
27fdfaf to
6fcaca3
Compare
cfzimmerman
reviewed
Sep 8, 2026
Contributor
There was a problem hiding this comment.
Is it possible to remove the multicast feature flag altogether? Or is there a path to doing so? Removing the cargo feature would be a giant win imo.
If compiling and running with no-multicast is still a requirement, I feel like we should still be testing that config in CI.
Contributor
Author
Yeah, this was my original intention (removing it altogether). I guess, let's do that now (going back to something @rmustacc mentioned in a sync awhile back). |
zeeshanlakhani
removed this pull request from stack #363
September 9, 2026 01:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the multicast feature on by default across crates and adds
--no-multicastto exclude mcast from the shipped P4 codegen build.With the feature on by default, the packet test harness no longer needs its MULTICAST conditional or any redundant setup.