userlib: Introduce Arch trait - #2705
Open
jamesmunns wants to merge 3 commits into
Open
jamesmunns wants to merge 3 commits into
jamesmunns wants to merge 3 commits into
Conversation
4 tasks
Contributor
Author
|
For reviewers, I've added some "big picture" notes in #2706 on how this PR fits into the bigger picture. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third PR in a series to be able to potentially run the kernal and tasks on a 64-bit host for testing purposes. This is currently based on #2704 (and #2703).
This PR introduces an
Archtrait foruserlib, similar to theArchtrait introduced for the kernel in #2704.This follows the pattern we've started using for BSP impls lately: We define a trait, each BSP (or Arch in this case) implements it, and we expose the One Selected Impl using cfgs as a commonly named type (here: Current) which the rest of the crate uses.
Like #2703, this one might be worth review commit-by-commit, as the total diff is a bit large, but the individual commits are each pretty straightforward.