Move the library, gpui and gpui-component to their latest revisions - #63
Conversation
`cargo update` across the whole tree, a week's worth of upstream. Every git source moved and nothing in the manifests had to be asked for a new version, so the diff is the lock file alone. - **whatsapp-rust** and its ten satellites: `ff0813ba` -> `210bf742`. A snapshot MAC mismatch now says whether it is the key or the fold (oxidezap/whatsapp-rust#1369), and a test harness bumps its version ahead of the IQ answer (#1368). All eleven still resolve from one git source on one branch, as the manifest requires. - **zed** (`gpui`, `gpui_platform` and their satellites): `399258fe` -> `76b1096c`, eighteen commits. Two of them reach this tree rather than the editor above it: `gpui` gates its blocking executor APIs on wasm (zed#63484), which is the compile-time form of the rule `exec/` already follows here, and `gpui_web` lets an application provide its own fonts (zed#63493). Neither changes a call this front end makes -- the wasm checks below are where that was verified rather than assumed. - **gpui-component** (and `-base`, `-assets`, `-macros`): `c6a68e0c` -> `c5ade488`, fourteen commits. The ones a window here can feel are the dialog's overlay coming back (#2891), a popup blocking the mouse behind it (#2887), the disabled switch fading its track rather than its thumb (#2886) and the Markdown table's wheel axis lock (#2890). ## The registry deps `hermit-abi` 0.5.3, `sval` and its eight satellites 2.22.0, `value-bag` 1.14.0 -- all transitive, all patch or minor. ## What `cargo update` still lists, and why it stays Unchanged from the last bump: the deliberate dual-major `getrandom` (0.4 for `wacore`, 0.2 for the older transitive dependency, each naming its own wasm backend, which is why they read as behind each other); `cocoa` and `generic-array`, transitive and not ours to pin; and the four `rtc-*` crates, which come from the library's VoIP stack. ## Verified `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets -- -D warnings` and `cargo test --workspace` all clean against the new revisions, plus `cargo +nightly check` on `wasm32-unknown-unknown` for both `oxidezap-gui` and `oxidezap-session` -- which is where the two gpui web changes above would have shown up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZQ28Vqpc3pCasXu3Rzzja
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
2 participants
cargo updateacross the whole tree, the week since #56. Every git sourcemoved and nothing in the manifests had to be asked for a new version, so the
diff is the lock file alone.
The git sources
ff0813ba→210bf742. Asnapshot MAC mismatch now says whether it is the key or the fold
(diag(appstate): say whether a snapshot MAC mismatch is the key or the fold whatsapp-rust#1369), and a test harness bumps its version ahead of
the IQ answer (fix(tests): move the harness version bump ahead of the IQ answer whatsapp-rust#1368). All eleven still resolve from
one git source on one branch, as the manifest requires.
gpui,gpui_platform,scheduler,sum_tree,refineable,zlog,ztracing,media,http_client, …):399258fe→76b1096c,eighteen commits. Two of them reach this tree rather than the editor above
it:
gpuigates its blocking executor APIs on wasm (gpui: Gate blocking executor APIs on WebAssembly zed-industries/zed#63484)— the compile-time form of the rule
exec/already follows here — andgpui_weblets an application provide its own fonts(gpui_web: Let applications provide fonts zed-industries/zed#63493). Neither changes a call this front end makes; the
wasm checks below are where that was verified rather than assumed.
-base,-assets,-macros):c6a68e0c→c5ade488, fourteen commits. The ones a window here can feel are thedialog's overlay coming back (dialog: Restore the overlay behind an open dialog longbridge/gpui-kit#2891), a popup
blocking the mouse behind it (#2887), the disabled switch fading its track
rather than its thumb (#2886) and the Markdown table's wheel axis lock
(#2890).
The registry deps
hermit-abi0.5.3,svaland its eight satellites 2.22.0,value-bag1.14.0— all transitive, all patch or minor.
What
cargo updatestill lists, and why it staysUnchanged from #56: the deliberate dual-major
getrandom(0.4 forwacore,0.2 for the older transitive dependency, both named so each can name its own
wasm backend, which is why they read as behind each other);
cocoaandgeneric-array, transitive and not ours to pin; and the fourrtc-*crates,which come from the library's VoIP stack rather than from a manifest here.
Verified
cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspace(every suite green) against the newrevisions, plus
cargo +nightly checkonwasm32-unknown-unknownfor bothoxidezap-guiandoxidezap-session— which is where the two gpui webchanges above would have shown up.
🤖 Generated with Claude Code
https://claude.ai/code/session_017ZQ28Vqpc3pCasXu3Rzzja
Generated by Claude Code
Summary by cubic
Moves
whatsapp-rust,zed(gpuiand its satellites), andgpui-componentto their latest revisions viacargo update. No manifests needed changes, so the diff is only the lock file.Dependencies
whatsapp-rustnow reports whether a snapshot MAC mismatch is in the key or the fold.gpuigates blocking executor APIs behind wasm andgpui_weblets an app supply fonts; no calls here change.gpui-componentrestores the dialog overlay, fixes a popup blocking the mouse, fades the disabled switch track instead of the thumb, and locks the Markdown table's wheel axis.hermit-abi,sval,value-bag) are all transitive patch/minor bumps.wasm32-unknown-unknownchecks pass against the new revisions.Written for commit 10193e3. Summary will update on new commits.