Move the library, gpui and gpui-component on again - #90
Conversation
`cargo update` on top of #69. The lock file alone, and only the git sources moved -- no registry crate had a new version to take. - **whatsapp-rust** and its ten satellites: `5370f021` -> `860744fb`. App state is folded, keyed and encoded the way WhatsApp Web does it (oxidezap/whatsapp-rust#1374), and a collection whose snapshot will not validate is now asked of the primary (#1375) -- the two together are the end of the MAC-mismatch thread the last three bumps carried the diagnostics for. - **zed** (`gpui`, `gpui_platform` and their satellites): `ce48461e` -> `5e28272c`. `gpui` locks touch scrolling to the dominant axis (zed#63553) and `gpui_web` tightens the web keyboard feel (zed#63533), which is the one this front end has a page to feel it in. - **gpui-component** (and `-base`, `-assets`, `-macros`): `c5ade488` -> `5cb09462`. Mostly pointer and layout fixes a window here can feel: a resizable handle no longer crushed to zero (#2899), drag auto-scroll stopping when the content mask collapses (#2902), hover selection no longer scrolling a command list (#2901). Verified by CI rather than locally, deliberately: this is a lock-file bump with no code change of its own, and the workspace build, the three platform checks, the MSRV job and the web test are the same suites a local run would repeat. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZQ28Vqpc3pCasXu3Rzzja
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
2 participants
cargo updateon top of #69. The lock file alone, and only the git sourcesmoved — no registry crate had a new version to take.
The git sources
5370f021→860744fb. App stateis folded, keyed and encoded the way WhatsApp Web actually does it
(Fold, key and encode app state the way WhatsApp Web actually does whatsapp-rust#1374), and a collection whose snapshot will not
validate is now asked of the primary (Ask the primary for a collection whose snapshot will not validate whatsapp-rust#1375) — the two
together close out the MAC-mismatch thread whose diagnostics the last three
bumps carried in.
gpui,gpui_platformand their satellites):ce48461e→5e28272c.gpuilocks touch scrolling to the dominant axis(gpui: Lock touch scrolling to the dominant axis zed-industries/zed#63553) and
gpui_webtightens the web keyboard feel(gpui_web: Tighten up web keyboard feel zed-industries/zed#63533), which is the one this front end has a page to
feel it in.
-base,-assets,-macros):c5ade488→5cb09462. Mostly pointer and layout fixes a window here can feel: aresizable handle no longer crushed to zero (resizable: Keep the handle's divider line from being crushed to zero size longbridge/gpui-component#2899),
drag auto-scroll stopping when the content mask collapses (#2902), hover
selection no longer scrolling a command list (#2901), and the dock resolving
tile resize by pointer travel (#2904).
Verified
By CI rather than locally, deliberately and at the author's ask: this is a
lock-file bump with no code change of its own, and the workspace build, the
three platform checks, the MSRV job and the web test are the same suites a
local run would repeat. I am watching the run and will push a fix if anything
goes red — the library's app-state rework is the one entry here with the reach
to break a call this tree makes.
🤖 Generated with Claude Code
https://claude.ai/code/session_017ZQ28Vqpc3pCasXu3Rzzja
Generated by Claude Code
Summary by cubic
Bumps the git sources in
Cargo.lockforwhatsapp-rust,zed, andgpui-componentto newer revisions. This is a lock-file-only change with no code changes in this repo.whatsapp-rustnow folds, keys, and encodes app state like WhatsApp Web, and re-fetches unvalidated snapshots from the primary, ending the MAC-mismatch diagnostics.gpuilocks touch scrolling to the dominant axis and tightens web keyboard feel.gpui-componentfixes a resizable handle crushing to zero, drag auto-scroll stopping, hover selection scrolling a command list, and dock tile resize by pointer travel.Written for commit 06d6349. Summary will update on new commits.