Repository navigation
Add Ruby 4.0 to testing matrix - #113
Merged
Merged
Conversation
Ruby 4.0 removes the CGI library and leaves only cgi/escape; requiring 'cgi' now loads a shim that warns under -w. CGI.escape is all the Google lookup uses, and cgi/escape provides it on every supported Ruby (2.5+). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TbAwVLZPUjfvaJGZQpMRfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4.0 was released on 2025‑12‑25 (latest patch 4.0.7). This adds it to the CI matrix.
It also changes
require 'cgi'torequire 'cgi/escape'inlib/timezone/lookup/google.rb. Ruby 4.0 removed the CGI library;require 'cgi'now loads a shim that prints a warning under-w("CGI library is removed from Ruby 4.0..."). The Google lookup only usesCGI.escape, whichcgi/escapedefines directly onCGIin every supported Ruby, back to 2.5.Testing
bundle exec rake testpasses with no CGI warning.test_googlecase covering client ID escaping (123&asdf→123%26asdf) passes.bundle exec rubocoppasses (the rubocop job stays pinned to Ruby 3.0; rubocop 1.5.1 doesn't run on 4.0).🤖 Generated with Claude Code
https://claude.ai/code/session_01TbAwVLZPUjfvaJGZQpMRfo
Generated by Claude Code