stackoverlay: switch ClickOverlay to using destroy for cleaning up StackOverlay - #1184
Open
alaviss wants to merge 2 commits into
Open
stackoverlay: switch ClickOverlay to using destroy for cleaning up StackOverlay#1184alaviss wants to merge 2 commits into
alaviss wants to merge 2 commits into
Conversation
ClickOverlay was re-implementing the destroy() method of StackOverlay, and its version is vastly out-of-date compared to StackOverlay.destroy. This could lead to leaking resources that are cleaned up in StackOverlay but not ClickOverlay. Call StackOverlay.destroy method directly to avoid this split-brain problem.
Ensure that the tracked source is always up-to-date to avoid false clearing by the destroy method.
Thesola10
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickOverlaywas using its own version of destroy forStackOverlay, which misses a few resources allocated by the latter.Switch to
StackOverlay.destroyto simplify the code and avoid resource leaks.