Fix multiple TODOs#89
Open
mertwole wants to merge 4 commits into
Open
Conversation
drskalman
requested changes
Jul 15, 2026
Collaborator
There was a problem hiding this comment.
Few questions and nits mostly :-)
Also could you make it to merge into https://github.com/paritytech/bls/tree/skalman/fix-audit-findings instead of master please?
| type M = Message; | ||
| type PKG = PublicKey<E>; | ||
|
|
||
| type PKnM = ::core::iter::Once<(Message, PublicKey<E>)>; |
Collaborator
There was a problem hiding this comment.
Could you explain me that how is replacing Once with ExactSizeIterator works?
|
|
||
| type M = &'a Message; | ||
| type PKG = &'a PublicKey<Self::E>; | ||
| type PKnM = ::std::collections::hash_map::Iter<'a, Message, PublicKey<E>>; |
Collaborator
There was a problem hiding this comment.
I believe the explicit use of hash_map was intentional to impose the hash_map's orders, do we know for sure if we remove the hash_map we get the same ordering?
|
|
||
| use core::borrow::Borrow; // BorrowMut | ||
| // We use BTreeMap instead of BTreeMap for no_std compatibility. | ||
| // We use BTreeMap instead of BTreeMap for no_std compatibility. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // We use BTreeMap instead of BTreeMap for no_std compatibility. | |
| // We use BTreeMap instead of HashMap for no_std compatibility. |
| //! TODO: Add serde support for serialization throughout. See | ||
| //! https://github.com/ebfull/pairing/pull/87#issuecomment-402397091 | ||
| //! https://github.com/poanetwork/hbbft/blob/38178af1244ddeca27f9d23750ca755af6e886ee/src/crypto/serde_impl.rs#L95 | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| //! | |
| //! Serialization for Public Keys and Signatures is provided via `serialize.rs::SerializableToBytes` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #88
Resolves #87
Benchmarks have shown that batching curve normalizations in
verifywon't give any significant performance gains (a difference was less than 1% in my tests)