Skip taproot coins in payjoin-cli#1600
Conversation
Coverage Report for CI Build 26908339625Coverage increased (+0.005%) to 85.363%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
zealsham
left a comment
There was a problem hiding this comment.
tACK.
i loaded a wallet with only P2tr as UTXO for sender and then repeated for receiver
aswell . payjoin-cli skipped those utxos
Error: No spendable UTXOs available in wallet. Please ensure your wallet has confirmed funds.
What kind of errors? I'm not totally convinced "we shouldn't support any of the state of the art outputs" is the path forward here yet. Are these tapscripts that can't be satisfied or something? Seems like more of a wallet hygiene problem than a payjoin-cli problem but the details are incomplete |
I found this bug when testing payjoins in liana where a taproot coin would be added to my payjoin-cli wallet and then the next time I would try to do a payjoin the latest utxo would be a taproot output and would then cause errors when trying to do a payjoin.
This PR simply skips taproot outputs as coins to be chosen in the payjoin-cli.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.