Skip to content

Skip taproot coins in payjoin-cli#1600

Open
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:skip-taproot-coins
Open

Skip taproot coins in payjoin-cli#1600
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:skip-taproot-coins

Conversation

@benalleng
Copy link
Copy Markdown
Collaborator

I found this bug when testing payjoins in liana where a taproot coin would be added to my payjoin-cli wallet and then the next time I would try to do a payjoin the latest utxo would be a taproot output and would then cause errors when trying to do a payjoin.

This PR simply skips taproot outputs as coins to be chosen in the payjoin-cli.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 26908339625

Coverage increased (+0.005%) to 85.363%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 6 of 6 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13862
Covered Lines: 11833
Line Coverage: 85.36%
Coverage Strength: 392.03 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@zealsham zealsham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

i loaded a wallet with only P2tr as UTXO for sender and then repeated for receiver
aswell . payjoin-cli skipped those utxos

Error: No spendable UTXOs available in wallet. Please ensure your wallet has confirmed funds.

@DanGould
Copy link
Copy Markdown
Contributor

DanGould commented Jun 5, 2026

I found this bug when testing payjoins in liana where a taproot coin would be added to my payjoin-cli wallet and then the next time I would try to do a payjoin the latest utxo would be a taproot output and would then cause errors when trying to do a payjoin.

What kind of errors? I'm not totally convinced "we shouldn't support any of the state of the art outputs" is the path forward here yet. Are these tapscripts that can't be satisfied or something? Seems like more of a wallet hygiene problem than a payjoin-cli problem but the details are incomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants