Repository navigation
Conversation
…usrc /etc/pegasus/pegasus.properties (monitord JSON encoding and the AMQP workflow catalog) was never read. The packaged Pegasus lives in a venv whose sysconfdir is venv/.../Pegasus/data/etc, and planning usually runs on the submit host, which has none of the image's files. A fresh hosted run's planned properties had neither key, and monitord wrote only to SQLite. On every start, the entrypoint now copies each property into ~/.pegasusrc, which every plan reads wherever it runs. A key the user already set there, even to an empty value, is left alone. Closes #668
Contributor
Author
|
Not doing this in Studio. The cause is in Pegasus's 6.0 packaging: the venv build's sysconfdir is inside the venv, so /etc/pegasus/pegasus.properties is ignored on every host. It will be fixed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/etc/pegasus/pegasus.propertiessetspegasus.monitord.encoding = jsonand the AMQP workflow catalog (msgs.pegasus.isi.edu), the same as on ACCESS Pegasus. In Studio it is never read:pegasus.home.sysconfdiris/usr/lib/pegasus/venv/lib/python3.13/site-packages/Pegasus/data/etc, not/etc/pegasus.Checked in a hosted pod: a fresh run's planned
pegasus.*.propertieshad neither key, andmonitord.loglisted only the two SQLite sinks.Change
On every start,
docker/entrypoint.shadds each property from/etc/pegasus/pegasus.propertiesto~/.pegasusrc. That file is in the shared home, and its lines already appear in every run's planned properties (the site-catalog settings arrive this way).~/.pegasusrcis left alone, even with an empty value, so a user can override a property or turn the AMQP sink off.pegasus.propertiesstill takes precedence.Tests
tests/test_pegasus_system_properties.py(9 tests) runs the entrypoint block with a temporary~/.pegasusrc. It covers adding to an existing file, creating a missing one, keeping a user's key, a second run adding nothing, dotted and prefix keys, comments and a missing trailing newline, and a missing system file.Not verified yet
Nobody has tested this live on the
:developimage. After a restart:~/.pegasusrcshould contain the two lines.The submit host must be able to reach
msgs.pegasus.isi.edu:5672.Closes #668