Repository navigation
Conversation
…ysconfdir The packaged Pegasus 6.0 planner reads pegasus.properties only from <venv>/.../Pegasus/data/etc, so the image's system properties (JSON monitord encoding, AMQP workflow catalog) were never applied. At build, ask Pegasus.cli._java.get_system_properties() where it looks and symlink the system file there; no-op once that is /etc/pegasus. Shared by the Dockerfile and the EL9 OOD image. Closes #675
fix(build): link /etc/pegasus/pegasus.properties into the planner's sysconfdir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the following, merged into
developafter #674, to main.Closes #675
Included (reviewed and merged into develop):
docker/pegasus/link-system-properties.shasks the packaged planner whichsysconfdirit uses (Pegasus.cli._java.get_system_properties(), which is<venv>/.../Pegasus/data/etc). It then symlinks/etc/pegasus/pegasus.propertiesthere, so the JSON monitord encoding and the AMQP workflow catalog apply to runs planned in the image. It does nothing once Pegasus reports/etc/pegasus. The Dockerfile and the EL9 OOD image both run it.Merging this publishes
:main, which production pulls on the next pod restart.Not covered: hosted runs are planned and monitored on the AP, so AMQP for them also needs the same link on the AP (salt, studio-system).
Not yet checked by hand on
:develop: whetherpegasus.propertiesexists as a link in/usr/lib/pegasus/venv/lib/python3.13/site-packages/Pegasus/data/etcin a fresh pod.