Remove false-positive debug assert hits against normative behavior. - #876
Open
gavin-dunlap-luminar wants to merge 1 commit into
Open
Conversation
gavin-dunlap-luminar
force-pushed
the
fix/correct-normative-debug-assertion-failures
branch
2 times, most recently
from
September 1, 2026 18:51
07fba68 to
fac1504
Compare
gavin-dunlap-luminar
force-pushed
the
fix/correct-normative-debug-assertion-failures
branch
from
September 1, 2026 18:52
fac1504 to
b27f9cf
Compare
gavin-dunlap-luminar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port::set_recommended_stateasserts !default_ds.slave_only in theM1 | M2arm. The assertion is wrogn and it panics debug builds of any slave-only instance on a conformant network. According to Figure 31 of IEEE 1588-2019, there is a connection from a BMC_MASTER recommendation to LISTENING. A slave-only instance is recommended M1 or M2 whenever it is the best clock in its domain (the only device powered up so far, or with an aged out grandmaster).Impact
Release builds are unaffected. Debug builds of slave-only instances panic on the first BMCA cycle that finds no better master. This makes
slave_only: trueunusable unless debug assertions are disabled for the whole crate. Encountered in the wild while utilizing this crate.