Add constant.finance to whitelist - #1848
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe whitelist now includes ChangesWhitelist Update
Priority: ⬇️ Low — Defer the whitelist update because it is a narrow two-line domain-classification change for a reported testnet false positive. Merge Risk: ⚪ Minimal · up to This adds constant.finance to the whitelist so matching sites are no longer classified as malicious. No concrete current-head merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
We would like to add
*.constant.financetowhitelist.yamlafter discovering that the Phantom browser extension currently identifies our website as malicious.About us
Constant Finance is a DeFi lending protocol currently under development. Our application is in public beta on a testnet and does not interact with mainnet.
The issue
When users visit our application, the Phantom browser extension blocks the page and displays the following warning:
We believe this is a false positive. Since the application currently operates only on a testnet, we would appreciate any information about the signals or source used to classify our domain as risky. Understanding the reason would help us investigate and address any specific concerns.
Steps we have taken
We have:
The warning page directs developers to this repository to report an issue. However, the repository README states that the fuzzylist and whitelist are not currently in active use, so it is unclear whether this change can affect the warning or where its underlying classification originates.
We are submitting this PR both as a request for assistance and as a public record that
constant.financeand its official subdomains belong to the Constant Finance project.Request
We have noticed that other legitimate projects have encountered similar warnings, including several requests in this repository.
It would be extremely helpful if Phantom could provide a clear public channel where developers can:
We would be grateful for guidance on the correct next step and for a review of
constant.finance.Thank you for your time and help.
Summary by CodeRabbit
New Features
*.constant.financethrough whitelist configuration.Configuration
nftplus.ioin the whitelist.