Compromise on validation#284
Merged
kamil-tekiela merged 1 commit intophp:masterfrom Apr 29, 2026
Merged
Conversation
Girgias
approved these changes
Apr 29, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Looks fine, although I would prefer to have Jing run by default as schema validation are the most likely reason for failure.
| echo "Command failed do you have Java installed?"; | ||
| echo "\nThe document didn't validate.\n"; | ||
|
|
||
| if ($ac['DETAILED_ERRORMSG'] === 'yes') { |
Member
There was a problem hiding this comment.
This should be the default IMHO.
Member
Author
There was a problem hiding this comment.
The default can be changed in another PR. I don't mind the default being YES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #170
This PR compromises by adding a fallback in case Java is not available. It also fixes the broken parameters which were made no-op.