Repository navigation
Conversation
devnexen
marked this pull request as ready for review
July 4, 2026 07:12
ndossche
approved these changes
Jul 4, 2026
Member
|
This may be backported to 8.4 |
Member
Author
|
was unable to reproduce on lower branches albeit the code path is similar-ish, the OOM bailout appear earlier on 8.4 and 8.5 it s more the maximum call stack size kind. |
Member
|
This patch should be safe anyway to backport |
devnexen
added a commit
that referenced
this pull request
Jul 4, 2026
* PHP-8.5: ext/soap: backport GH-22586 fix.
pull Bot
pushed a commit
to dolfly/php-src
that referenced
this pull request
Jul 4, 2026
* PHP-8.4: ext/soap: backport phpGH-22586 fix.
Member
|
Any reason only the patch was backported, but not the test? I guess because it didn't reproduce there? |
Member
Author
|
All addressed here. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…out.
Fix #22585