Repository navigation
[%pS migration] Use %pS in ext/phar - #23166
Conversation
LamentXU123
changed the title
%pS migration] Use %pS in ext/phar/*%pS migration] Use %pS in ext/phar
0e5efb5 to
2af0ebf
Compare
2af0ebf to
dcaf197
Compare
LamentXU123
left a comment
LamentXU123
left a comment
There was a problem hiding this comment.
Thank you. If you are fine to merge yourself please go ahead :)
Since you're the extension maintainer: any preference on if this is squashed as a single commit, or done individually? Since the changes to each file are entirely separate can be done separately for clearer history tracking
fixing |
|
I don't have strong preferrence in this topic. If you'd prefer rebase and merge just do it. |
dcaf197 to
90a5c12
Compare
Yeah, I was doing a bunch of these mechanically when I created them so was also going to do a confirmation check before merging, but thanks for catching that! |
|
|
||
| /* zip or tar-based phar */ | ||
| name = zend_strpprintf(4096, "phar://%s/%s", ZSTR_VAL(file_handle->filename), ".phar/stub.php"); | ||
| name = zend_strpprintf(4096, "phar://%pS/%s", file_handle->filename, ".phar/stub.php"); |
There was a problem hiding this comment.
as a follow up on master, we don't need %s for ".phar/stub.php" since we know the exact literal...
There was a problem hiding this comment.
Agreed. You can create a seperate commit about this.
|
Test failures are unrelated; since I need to upmerge this anyway I'll merge locally so that commits stay signed |
2 participants
No description provided.