Repository navigation
lexbor: Merge upstream fixes - #23660
alexandre-daubois wants to merge 1 commit into
Conversation
alexandre-daubois
changed the title
d3dac2c to
d18b498
Compare
There was a problem hiding this comment.
FWIW: Historically we didn't add tests for upstream issues (because the fix is already tested upstream), so for all I care these can be dropped.
There was a problem hiding this comment.
FWIW: I'm happy with these tests, because these make sure that no matter which library or library version we use under the hood, the asserted edge cases satisfy the related specifications, and most tests already check lexbor's and uriparser's own behavior, not just the php-src integration.
|
@alexandre-daubois FYI: lexbor/lexbor#396 is another candidate which should also land when merged. |
|
Thanks Máté! Keeping an eye on it |
|
I subscribed to your PRs, I'll update everything once the two last are merged 👍 |
d18b498 to
8ae2fb5
Compare
alexandre-daubois
changed the title
8ae2fb5 to
6196cf7
Compare
d7699bd to
7ec1992
Compare
|
(I've just added two more PRs to the list above) |
7ec1992 to
ac080b8
Compare
|
@kocsismate is lexbor/lexbor#396 the last one or you'd like to embed other PRs? |
15d4247 to
e243135
Compare
lexbor/lexbor@859f100 lexbor/lexbor@a36e09a lexbor/lexbor@b0f7412 lexbor/lexbor@1b215a8 lexbor/lexbor@385afff lexbor/lexbor@e6c068f lexbor/lexbor@327a8b6 lexbor/lexbor@917742f lexbor/lexbor@e89c258 Only the source/lexbor/url part of lexbor/lexbor@327a8b6 and lexbor/lexbor@e89c258 is carried: the first squash also contains unrelated HTML tree construction changes, and the second documents a percent-encoder API that this branch does not bundle.
e243135 to
2c5bac1
Compare
|
@alexandre-daubois Yes, that's the last one. Likely, it won't be merged directly, as the author expressed in this comment: lexbor/lexbor#396 (comment) It's also OK to merge your changes without that one, and we could add it later (maybe only for master). |
|
Alright, I'll take care of (up)merging this one soon. Feel free to ping me wherever relevant 🙂 |
|
Merge done! Closed by beee544 |
After lexbor/lexbor#415 was merged to Lexbor and the change was applied to ext/lexbor via php#23660, the temporary functions can be replaced with their counterpart in Lexbor.
3 participants
Once this one and #23659 are merged, I'll have a look to actually bump lexbor to 3.0.1 on master.