Repository navigation
Conversation
iliaal
force-pushed
the
promote/pdo-getgc-boundparams
branch
from
September 29, 2026 15:31
fc100ce to
99f1f38
Compare
iliaal
changed the title
Member
|
The SQLite tests are failing, so some changes may be needed. |
PDOStatement's get_gc handler never reported bound_params or bound_columns, so reference cycles through a bindParam()/bindColumn() variable or its driver options stayed invisible to the collector and were never reclaimed. Report the parameter and driver_params zvals of both tables.
iliaal
force-pushed
the
promote/pdo-getgc-boundparams
branch
from
September 30, 2026 13:23
99f1f38 to
7a44957
Compare
Member
Author
|
Windows loaded pdo_sqlite twice ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDOStatement's get_gc handler never walked bound_params or bound_columns, so a reference cycle through a bindParam() or bindColumn() argument or its driver options stayed invisible to the collector. The test binds one object in each of the four slots (parameter and driver option, for both params and columns) and expects all four collected after gc_collect_cycles().
Rebased onto GH-23936, which fixed the driver_params refcount this PR also carried before.