Repository navigation
Conversation
The current signature is effectively useless every call uses the _ex variant to be able to grab the FCC and usually the error message. Something the current signature does not provide, and instead offers parameters that most call sites don't care about.
As the new signature is actually useful now
Girgias
marked this pull request as ready for review
September 29, 2026 17:24
Girgias
requested review from
DanielEScherzer,
SakiTakamachi,
bukka,
devnexen and
dstogov
as code owners
September 29, 2026 17:24
TimWolla
reviewed
Sep 29, 2026
| header interoperability is not required. | ||
| - The signature of zend_is_callable() has been changed to | ||
| zend_is_callable(const zval *callable, zend_fcall_info_cache *fcc, char **error) | ||
| from zend_is_callable(const zval *callable, uint32_t check_flags, zend_string **callable_name) |
Member
There was a problem hiding this comment.
Missing . at the end, and perhaps add justification: “Allowing to simplify the most common case for zend_is_callable_ex()” or something like that: The goal if for folks to not needing to use zend_is_callable_ex() and making it explicit that they might be able to simplify is probably valuable.
Member
Author
There was a problem hiding this comment.
Improved wording, let me know what you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current signature of
zend_is_callable()has a single use showcasing how useless this definition of it is.These commits change the signature from
bool zend_is_callable(const zval *callable, uint32_t check_flags, zend_string **callable_name)tobool zend_is_callable(const zval *callable, zend_fcall_info_cache *fcc, char **error)and utilize this newer signature when possible.