Repository navigation
Conversation
…n method calls XMLW_NAME_CHK hardcodes the procedural argument number, but the same implementations back the XMLWriter method aliases, which have no writer parameter. Shift the number by one when the call has a $this.
ndossche
reviewed
Oct 5, 2026
| #define XMLW_NAME_CHK(__arg_no, __subject) \ | ||
| if (xmlValidateName((xmlChar *) name, 0) != 0) { \ | ||
| zend_argument_value_error(__arg_no, "must be a valid %s, \"%s\" given", __subject, name); \ | ||
| zend_argument_value_error(getThis() != NULL ? (__arg_no) - 1 : (__arg_no), "must be a valid %s, \"%s\" given", __subject, name); \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLW_NAME_CHKhardcodes the procedural argument number, so theXMLWritermethod aliases report the wrong one:The macro now shifts the number by one when the call has a
$this. Procedural numbers are unchanged. The new test covers the 16 affected methods and their procedural counterparts.