Repository navigation
Fix EG(record_errors) leak when compilation bails out - #24149
Open
ptondereau wants to merge 1 commit into
Open
ptondereau wants to merge 1 commit into
ptondereau wants to merge 1 commit into
Conversation
github-actions
Bot
added
Category: Engine
Extension: opcache
Extension: zend_test
labels
Member
|
This needs a NEWS entry, since warnings after a fatal compile error are silently dropped in 8.5. |
Since 7b3e68f, a bailout in compile_file() or in the opcache optimizer leaves EG(record_errors) true. The next compilation fails the assertion "Error recording already enabled", and PHP does not show later warnings. Add a zend_catch block to these three regions, as opcache_compile_file() does. Add zend_test.fatal_error_in_pass to do a test of the optimizer.
ptondereau
force-pushed
the
fix-record-errors-bailout
branch
from
October 6, 2026 12:46
d8e74ff to
82b29ed
Compare
Author
Thanks! Done, and sorry I wasn't very aware of the contribution guideline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 7b3e68f, a bailout in
compile_file()or in the opcache optimizer leavesEG(record_errors)true. The next compilation fails the assertionError recording already enabled, and PHP does not show later warnings.This adds a
zend_catchblock to the three regions, asopcache_compile_file()does and the newzend_test.fatal_error_in_passINI setting causes a fatal error in the optimizer for the tests.