Repository navigation
Conversation
Problem: Potential NULL pointer dereference when op2 is NULL and is passed to ct_eval_fetch_obj(). Solution: Check op2 before calling ct_eval_fetch_obj(). Signed-off-by: Timofey Mishin <t.mishin@fobos-nt.ru> Signed-off-by: Georgij Tsarin <crystarm@altlinux.org>
Member
|
False positive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_op2_value() can return NULL when the SSA operand is unavailable. The ZEND_ASSIGN_OBJ_OP path did not check op2 before passing it to ct_eval_fetch_obj(), which eventually dereferences it in fetch_obj_prop().
Add a NULL check before calling ct_eval_fetch_obj() to prevent the invalid dereference.