Repository navigation
sodium: Use opaque objects for SHAKE state - #24351
Conversation
TimWolla
changed the title
| function sodium_crypto_xof_shake128_init(?int $domain = null): SodiumCryptoXofShake128State {} | ||
|
|
||
| function sodium_crypto_xof_shake128_update(string &$state, string $message): true {} | ||
| function sodium_crypto_xof_shake128_update(SodiumCryptoXofShake128State $state, string $message): void {} |
There was a problem hiding this comment.
Should $message also have #[\SensitiveParameter]?
There was a problem hiding this comment.
BTW, do we need this before merging?
There was a problem hiding this comment.
BTW, do we need this before merging?
Not necessary before merging. This is a simple stub change (and also not a breaking change with regard to the API), this can happen separately and probably also makes sense to have as a separate commit.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1ae4cac to
0f9e704
Compare
|
This seems to address the original issue, we just need to decide if it is too late for PHP 8.6 |
mbeccati
left a comment
mbeccati
left a comment
There was a problem hiding this comment.
On behalf of the 8.6 RMs /cc @svpernova09
* PHP-8.6: sodium: Use opaque objects for SHAKE state (#24351)
|
Will also need UPRGADING for the new classes |
Alternative to #24182.