Repository navigation
Report PHPStan attributes not covered by backward compatibility promise - #6916
Merged
Merged
Conversation
Using an attribute from the PHPStan namespace outside of PHPStan is reported with the phpstanApi.attribute identifier unless the attribute class has @api. Conditional, AutowiredService, NonAutowiredService, RegisteredRule, RegisteredCollector and GenerateFactory are @api, including their constructors, so that new RegisteredRule(...) in Conditional's arguments is not reported by ApiInstantiationRule. Amp-Thread-ID: https://ampcode.com/threads/T-01a19cd4-be31-75b4-bd15-67786eff5983
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of #6283, done separately:
AttributesChecknow reports using an attribute from thePHPStan\namespace outside of PHPStan when the attribute class isn't@api, with thephpstanApi.attributeidentifier. The message and tip match the otherphpstanApi.*rules, and "outside of PHPStan" is decided byApiRuleHelper::isPhpStanCode(). It's inAttributesCheckrather than a new rule, so it covers every attribute position. There's no bleeding-edge toggle because no existing code outside PHPStan uses PHPStan attributes yet.@apiattributes:Conditional,AutowiredService,NonAutowiredService,RegisteredRule,RegisteredCollector,GenerateFactoryandAutowiredParameter. Their constructors are@apitoo. OtherwiseApiInstantiationRulereportsnew RegisteredRule(...)inside#[Conditional(...)].Everything else, such as
ContainerExtension,AutowiredExtensions,ExtensionInterfaceandValidatesStubFiles, is reported.