Fix intent classification from semantic main request#143
Conversation
pilipilisbot
left a comment
There was a problem hiding this comment.
Approved. I reviewed the classifier prompt/resource changes, the new metadata propagation in IntentClassification.to_metadata(), and the queue integration path that stores the classifier metadata and applies the LLM result only when valid/confident. The decomposition fields are optional in metadata, so existing callers remain compatible, while the packaged prompt now explicitly asks the classifier to separate the main request from subordinate rationale before choosing work_intent.
Checks run locally against the PR worktree using the repository venv with PYTHONPATH=src:
../github-agent-bridge/.venv/bin/python -m pytest tests/test_intent_classifier.py tests/test_queue.py tests/test_policy.py tests/test_packaged_resources.pyResult: 47 passed. GitHub Actions are also green for dashboard and Python 3.11/3.12 pytest.
|
Post-merge cleanup complete for PR #143: removed the clean dedicated worktree |
pilipilisbot
left a comment
There was a problem hiding this comment.
Reviewed the merged PR state again: current head c2da9f2 had already been formally approved, the PR is merged, and the focused classifier/queue/policy/resource suite passes locally. No further changes requested.
Summary
work_intentmain_requestandsubordinate_reasonin classifier metadata for easier auditsVerification
.venv/bin/pytest tests/test_intent_classifier.py.venv/bin/pytest tests/test_intent_classifier.py tests/test_queue.py tests/test_policy.py tests/test_packaged_resources.pygpt-5.4-miniprompt check on@giscebot fes una pull request per cada notificació...returnedreply_comment/work_allowedwith confidence0.96