feat: respect system dark mode in dashboard#147
Merged
Conversation
Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
Closed
Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
Owner
|
@pilipilisbot revisa els conflictes |
Resolve packaged dashboard asset conflicts after the web-push dashboard updates landed on main. Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
Owner
Author
|
Conflicts resolved by merging the updated Pushed commit: Local verification passed:
GitHub now shows the PR as merged; CI for the pushed head was still pending when I checked. |
Owner
Author
|
Follow-up on the merged PR: #147 is merged, and the refreshed GitHub Actions run for the merged head is green.
No further code changes were needed after the conflict-resolution merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-color-scheme.white,slate, and status-color utility usage.prefers-color-schememedia queries in the packaged dashboard build.Closes #146.
Tests
npm testnpm run buildpytest -q@media (prefers-color-scheme: dark).--color-scheme=lightand--color-scheme=darkagainst the Vite dev server.Screenshots
Dark-mode screenshot capture succeeded locally at
/tmp/gab-dashboard-dark.png, but I could not upload it to GitHub from this environment becausegh-imagerequires a browseruser_sessioncookie orGH_SESSION_TOKEN; only token-basedghauth is available here.