Conversation
* tici * address comments * address comments * test (cherry picked from commit d86730c)
* impl * proto * fix (cherry picked from commit 809a4e7)
* save work Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> * typo * add rpc * fix * proto: model versioned ranges as VersionedKeyRange * proto: drop reserved range_versions * proto: use uint64 for read_ts --------- Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> (cherry picked from commit fa40b23)
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> (cherry picked from commit f4a0f7a)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe protobuf contracts add versioned point-range lookups, TiCI shard metadata, estimate-count messages, MPP routing data, and two RPC endpoints. ChangesTiCI protocol extensions
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The protocol additions have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Buf (1.72.0)proto/coprocessor.protofatal: unable to access 'https://github.com/pingcap/kvproto.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server proto/mpp.protofatal: unable to access 'https://github.com/pingcap/kvproto.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server proto/tikvpb.protofatal: unable to access 'https://github.com/pingcap/kvproto.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit carries ranges bright, Comment |
Summary
Backport the existing FTS/TiCI protocol stack to
feature/release-8.5-ftsfor pingcap/tidb#71280.Cherry-pick the five previously adapted commits from
cp-fts-858-kvproto(47bcf5dc38ad): #1319, #1332, #1356, #1457 and #1432. They add shard metadata, versioned ranges and services, estimate-count RPCs, and MPP shard dispatch. Each commit retains its cherry-pick provenance.The target starts at
ab2787838a97; retain its #1524 resource-usage change. The resulting tree differs from the old FTS branch only by that target change. No backup metadata schema changes.Validation
go test -mod=readonly ./pkg/...passed (generated Go packages compile; most have no tests).Summary by CodeRabbit