Skip to content

Transactions may return ordinary errors when the commit result is undetermined #71585

Description

@gengliqi

1. Minimal reproduce step (Required)

Trigger RPC failures or cancellation during transaction commit, for example by losing a successful commit/prewrite response and failing a subsequent retry.

See tikv/client-go#2062 for the affected paths.

2. What did you expect to see? (Required)

When the commit result remains undetermined, TiDB should close the client connection.

3. What did you see instead (Required)

TiDB may return an ordinary SQL error instead of closing the connection. Applications could then retry an operation that has already committed.

The underlying client-go issues are fixed by tikv/client-go#2063.

4. What is your TiDB version? (Required)

master

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions