Skip to content

Add terminal Nerd Font fallbacks#1919

Open
Specter242 wants to merge 1 commit intopingdotgg:mainfrom
Specter242:codex/terminal-nerd-font-fallback
Open

Add terminal Nerd Font fallbacks#1919
Specter242 wants to merge 1 commit intopingdotgg:mainfrom
Specter242:codex/terminal-nerd-font-fallback

Conversation

@Specter242
Copy link
Copy Markdown

@Specter242 Specter242 commented Apr 11, 2026

What changed

Adds a named terminal font-family stack for the thread terminal that preserves the existing default fonts first, then adds common Nerd Font fallbacks before the final generic monospace fallback.

This keeps the current default appearance where SF Mono, Consolas, Liberation Mono, or Menlo work, while allowing Powerline/Nerd Font prompt glyphs to render when an installed Nerd Font can cover missing glyphs.

Closes #1918.

Why

The integrated terminal currently ends its fixed font stack at generic monospace. On Linux, shell prompts that use Nerd Font or Powerline glyphs can render as boxes/unknown characters even when a compatible Nerd Font is installed.

This is intentionally not a configurable terminal-font setting. PR #1572 was closed because a broader appearance system is planned; this PR only adds fallback fonts to the existing stack.

UI notes

Before, prompt glyphs render as boxes/unknown characters:

Terminal prompt before fallback fonts, showing missing glyph boxes

After, installed Nerd Font fallbacks cover the prompt glyphs:

Terminal prompt after fallback fonts, showing glyphs rendered

The screenshots are cropped to show only the terminal prompt area.

Validation

  • bun fmt
  • bun lint passes with one existing eslint-plugin-unicorn(consistent-function-scoping) warning in apps/web/src/environments/runtime/catalog.test.ts
  • bun typecheck passes with Bun 1.3.9 and Node 24.13.1

Note

Add Nerd Font fallbacks to the terminal font family list

Extracts the xterm fontFamily option into a TERMINAL_FONT_FAMILY constant in ThreadTerminalDrawer.tsx, expanding the fallback list to include common Nerd Font variants alongside existing monospaced defaults.

Macroscope summarized 044970f.


Note

Low Risk
Low risk UI-only change that adjusts the xterm fontFamily stack; no behavior, data, or security logic is modified.

Overview
Updates the integrated thread terminal to use a shared TERMINAL_FONT_FAMILY constant and expands the font fallback stack to include common Nerd Font variants (while keeping the existing default fonts first), improving rendering of Powerline/Nerd Font prompt glyphs when those fonts are installed.

Reviewed by Cursor Bugbot for commit 044970f. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7159a7bf-ffcc-42bb-a729-d260b8035bbb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 11, 2026
@Specter242 Specter242 changed the title [codex] Add terminal Nerd Font fallbacks Add terminal Nerd Font fallbacks Apr 11, 2026
@Specter242 Specter242 marked this pull request as ready for review April 11, 2026 03:02
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 11, 2026

Approvability

Verdict: Approved

This change adds Nerd Font fallbacks to the terminal's font-family CSS property while preserving all existing fonts in order. It's a purely cosmetic change to support better glyph rendering, with no runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@Specter242 Specter242 force-pushed the codex/terminal-nerd-font-fallback branch from 443d780 to 044970f Compare April 12, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal font stack lacks Nerd Font fallbacks for prompt glyphs

1 participant