Skip to content

Remove Vote.Verify()#3837

Draft
ilgyu-yi wants to merge 1 commit into
planetarium:mainfrom
ilgyu-yi:chore/clean-consensus
Draft

Remove Vote.Verify()#3837
ilgyu-yi wants to merge 1 commit into
planetarium:mainfrom
ilgyu-yi:chore/clean-consensus

Conversation

@ilgyu-yi

Copy link
Copy Markdown
Contributor

Context

  1. Vote is verified on the constructor
  2. Vote always have non-null ValidatorPublicKey.

@ilgyu-yi ilgyu-yi force-pushed the chore/clean-consensus branch 3 times, most recently from 9f52180 to f13ade5 Compare June 20, 2024 06:55
@riemannulus riemannulus force-pushed the chore/clean-consensus branch from f13ade5 to 1f00fc0 Compare June 20, 2024 07:05
@ilgyu-yi ilgyu-yi force-pushed the chore/clean-consensus branch from 1f00fc0 to f367ec7 Compare June 20, 2024 07:16
@ilgyu-yi ilgyu-yi marked this pull request as draft June 20, 2024 09:15
@ilgyu-yi

Copy link
Copy Markdown
Contributor Author

Seems to be fail on Libplanet.Net.Tests.Consensus.ContextNonProposerTest.EnterPreVoteNilOneThird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant