-
Notifications
You must be signed in to change notification settings - Fork 0
CG-1956 multi validator updates #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carl-adams-planet
wants to merge
11
commits into
main
Choose a base branch
from
carl/CG-1956--multi-validator-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
abed07e
Claude and nox updates.
carl-adams-planet 254114b
nox
carl-adams-planet 2419260
WIP
carl-adams-planet 19c7ca1
WIP
carl-adams-planet 8916c65
fix typo
carl-adams-planet 2ad9ce4
test update
carl-adams-planet 9824330
lint and doc fixes.
carl-adams-planet b3d8098
minor fix
carl-adams-planet fcd78a6
update changelog
carl-adams-planet 0a7dd8e
pin black for now
carl-adams-planet 8d77b49
test updates
carl-adams-planet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| name: check-all | ||
| description: Run the full default nox session suite (lint, test, security scan). Equivalent to CI pipeline checks. | ||
| allowed-tools: Bash | ||
| --- | ||
|
|
||
| Run the full default nox session suite: black lint check, pytest, semgrep security scan, mypy, pyflakes, and pylint. | ||
|
|
||
| This is equivalent to the CI pipeline checks. | ||
|
|
||
| Run: `nox` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| name: format | ||
| description: Auto-format code using Black via nox. | ||
| allowed-tools: Bash | ||
| --- | ||
|
|
||
| Auto-format code using Black via nox. | ||
|
|
||
| Run: `nox -s black_format` | ||
|
|
||
| Black is configured in pyproject.toml with line-length=119. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| name: lint | ||
| description: Run all linting checks (black, pyflakes, pylint, mypy) using nox. | ||
| allowed-tools: Bash | ||
| --- | ||
|
|
||
| Run all linting checks using nox. This runs black (formatting check), pyflakes, pylint, and mypy. | ||
|
|
||
| Run: `nox -s black_lint pyflakes_src pyflakes_examples pyflakes_tests pylint_src pylint_examples pylint_tests mypy` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| name: security-scan | ||
| description: Run semgrep security scan on source code using nox. | ||
| allowed-tools: Bash | ||
| --- | ||
|
|
||
| Run semgrep security scan on the source code using nox. | ||
|
|
||
| Run: `nox -s semgrep_src` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| name: test | ||
| description: Run unit tests using nox. Use when the user wants to run tests. | ||
| allowed-tools: Bash | ||
| --- | ||
|
|
||
| Run unit tests using nox. Pass any additional arguments through to pytest via nox's posargs. | ||
|
|
||
| Examples: | ||
| - Full unit test suite: `nox -s pytest` | ||
| - Tests matching a keyword: `nox -s pytest -- -k "test_name"` | ||
| - Specific test file: `nox -s pytest -- tests/test_planet_auth/unit/path/to/test_file.py` | ||
|
|
||
| Run: `nox -s pytest -- $ARGUMENTS` | ||
|
|
||
| Note: When `-k` is used, nox automatically disables coverage (`--no-cov`). | ||
| Default test paths are configured in pyproject.toml and include `tests/test_planet_auth/unit` and `tests/test_planet_auth_utils/unit`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching
nox.options.reuse_existing_virtualenvstoTruecan lead to non-reproducible lint/test results when dependencies or Python versions change (stale env contamination), especially in shared dev environments. Consider keeping thisFalseby default (or gating it behind an environment variable) while still allowing local opt-in for faster iteration.