Rename government cloud environments to BleuCloud, DelosCloud, and GovSGCloud#1245
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates PnP.Framework’s sovereign/government cloud environment naming to align with first-party (1P) terminology and reduce confusion, including corresponding endpoint/authority mappings used by AuthenticationManager.
Changes:
- Renamed
AzureEnvironmentmembers fromGovFr/GovDe/GovSgtoBleuCloud/DelosCloud/GovSGCloud. - Updated environment detection logic (TLD-based) to return the renamed enum values.
- Updated Microsoft365Environment-to-AzureEnvironment mappings and authority/endpoint selection to use the renamed values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/PnP.Framework/Extensions/InternalClientContextExtensions.cs | Updates TLD-based environment inference to return the renamed sovereign cloud enum values. |
| src/lib/PnP.Framework/AuthenticationManager.cs | Renames AzureEnvironment members and updates all related endpoint/authority mappings to the new names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
+61
| BleuCloud = 7, | ||
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| GovDe = 8, | ||
| DelosCloud = 8, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming it align with 1P tooling and avoid confusion
Depends on PR:
PnPCore/1787