Conversation
lionel-
added this pull request to stack #1412
September 18, 2026 17:45
lionel-
force-pushed
the
oak-query/recovery
branch
from
September 18, 2026 17:53
ef899bb to
7c5db0c
Compare
lionel-
force-pushed
the
oak-query/recovery
branch
from
September 20, 2026 09:27
7c5db0c to
031c860
Compare
lionel-
force-pushed
the
oak-query/recovery
branch
from
September 23, 2026 06:43
031c860 to
618df1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1409
This PR makes the invocation of cycle recovery handlers observable in tests.
All recovery handlers now call a
record()helper that is a noop everywhere except in test builds. With this in place, tests can now trace which recovery handler fired in any given cycle. A bunch of tests use it to snapshot recovery behaviour under known cycle scenarios.This is useful:
To monitor changes to our recovery mechanism after changing or refactoring Salsa code.
The upcoming fuzz PR is another consumer of the records to trace which handlers fire before and after edits, verify that corpus cases do reach intended recovery paths, etc.
Positron Release Notes
New Features
Bug Fixes