Repository navigation
NJ/NY and crawl data updates - #141
Conversation
|
I made some major edits to this branch including making tables/charts fit without having to scroll within them, and also changing a lot of the language used on the page to more accurately reflect what we want to say. Happy to discuss my changes in our meeting today or another one later @mccoogp, let me know. |
|
I realized I added in the AugSep and NJ_NY data directly through the generated datasts.json, but this is in git ignore because it's supposed to be handled by the generator. It wasn't working for all of these added datasets because it didn't know how to deal with multiple state names and because of the sep vs sept naming inconsistency. This is fixed now so all of the data should load properly. I also made some small edits to the NJ page. |
|
Looked through all changes, I approve! @mccoogp feel free to merge and close all issues associated with this PR. |
The majority of these changes are updating the UI with the findings of privacy-tech-lab/gpc-web-crawler#345
Across the UI, NJ has been renamed to NJ/NY, and whenever it is selected a warning pops up with a longer explanation at the end which points them to more information.

The same popup appears when selecting NJ/NY in the data table and GPC breakdown. This popup only occurs when NJ/NY is selected.
When clicking on the NJ/NY warning popup, it takes you to a separate page that breaks down the findings described in https://docs.google.com/spreadsheets/d/1fVdlDKdnzLb1XFmGooXaQbuF7XYzTx34jUsT6kWvmyQ/edit?gid=567337877#gid=567337877.
I would love both @KyleQ-hub and @RubyFri to thoroughly verify all of the information on this page, and take over edits of the page if they would like.
The AugSep has been added to the crawler along with redownloading all of the previous crawl data because it was never updated with the redone post-processing of privacy-tech-lab/gpc-web-crawler#313
I've also made two smaller changes to edit columns in accordance with Ruby's comments in #135. The compliance results descriptions now include "None" as an option. Site ID has also been added back as an option for edit columns.