Repository navigation
small changes to feature_engineering.py - #16
Open
jeromedockes wants to merge 6 commits into
Open
jeromedockes wants to merge 6 commits into
jeromedockes wants to merge 6 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a proposal from a quick pass on the first notebook
there are no substantial changes to the content, just reordering a few things (e.g. showing loaded raw data before defining the resampling), and also I suggest a function name change: "load" here is ambiguous (load on the electricity grid vs loading data) so I suggest in variable and function names to prefer "demand" to refer to electricity load and "fetch" (could also be "read") for loading data