Make filters for notes get#24
Open
ArtemBratyashin wants to merge 4 commits into
Open
Conversation
petrCher
requested changes
Jun 23, 2026
Member
|
обязательно после исправлений протестируй пожалуйста локально, сам посоздавай данные и посмотри грамотно ли работает, может я что-то случайно не заметил или не учел при ревью |
Contributor
Author
|
Проверил все в свагере. Сделал 2 Note и поселектил их через разные группы и сервисы |
petrCher
requested changes
Jun 24, 2026
| status: str, | ||
| asc_order: bool, | ||
| type_id: Optional[int] = None, | ||
| limit: int = 100, |
Member
There was a problem hiding this comment.
limit и offset не обязательно задавать, так как они все равно придут
только None добавлять надо, так как None не включен в int, str и тд
| groups_id: Optional[List[int]] = None, | ||
| services_id: Optional[List[int]] = None, | ||
| status: Optional[str] = None, | ||
| asc_order: Optional[bool] = True, |
| def search_by_status(self, status: Optional[str] = None) -> bool: | ||
| if status == "active": | ||
| return Note.status == "active" | ||
| if status == "archived": |
Member
There was a problem hiding this comment.
лучше делать elif, чтобы сократить время на запрос
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Добавил ручку фильтрации.
Closes #17
Детали реализации
Сделал функцию фильтрации в сервисах, как это сделано в других ручках проекта. Фильтрацию реализовал по аналогии с рентал.
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?