fix(middleware): validate ref query param before storing as referral_code cookie#78
Open
forgou37 wants to merge 1 commit into
Open
fix(middleware): validate ref query param before storing as referral_code cookie#78forgou37 wants to merge 1 commit into
forgou37 wants to merge 1 commit into
Conversation
…code cookie Without validation an attacker can craft a URL with an arbitrary ?ref= value to inject a fake referral code (referral fraud) or send an oversized value that bloats the cookie header and risks dropping the auth cookie. Add a strict alphanumeric + hyphen/underscore allowlist capped at 64 characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
proxy.tsstores the raw?ref=query parameter into areferral_codecookie with no validation:Two issues:
?ref=value bloats the cookie header. Browsers cap total cookie size per domain (~4 KB); a largereferral_codevalue can cause thesb-auth-tokenauth cookie to be dropped, logging users out.Fix
Adds a strict allowlist regex (
/^[a-zA-Z0-9_-]{1,64}$/) before writing the cookie. Values that do not match are silently ignored — same UX for legitimate users, attack surface closed.Test