Skip to content

fix(release): follow managed testsuite v1 - #409

Draft
bketelsen wants to merge 1 commit into
projectbluefin:mainfrom
bketelsen:fix/testsuite-v1-release-gate
Draft

fix(release): follow managed testsuite v1#409
bketelsen wants to merge 1 commit into
projectbluefin:mainfrom
bketelsen:fix/testsuite-v1-release-gate

Conversation

@bketelsen

Copy link
Copy Markdown

What does this change?

Bluefin stable promotion passes test_ref: v1 to testsuite, but the nested reusable workflow itself is pinned to an older SHA. That updates checked-out tests while freezing workflow-level fixes such as testsuite#691's VM disk sizing, so the NVIDIA release gate would remain blocked after the testsuite fix merges.

  • call the trusted first-party testsuite workflow through its managed @v1 tag
  • disable Renovate management for that dependency so config:best-practices cannot restore the stale digest pin
  • document the separate workflow-definition and test-checkout refs

The Security Gate for moving this first-party workflow to managed v1 was explicitly approved during implementation. Runtime recovery still depends on testsuite#691 and testsuite#692 passing review and live E2E validation.

Validation

  • pre-commit run --files .github/workflows/reusable-execute-release.yml .github/renovate.json5 docs/skills/composite-actions/reusable-workflow.md
  • actionlint .github/workflows/reusable-execute-release.yml
  • python3 scripts/check-self-repository-references.py
  • python3 scripts/check-consumer-contract.py
  • renovate-config-validator --strict .github/renovate.json5 with Renovate 44.14.7

Consumer validation

Consumer PR: projectbluefin/bluefin#1014
Consumer CI run: https://github.com/projectbluefin/bluefin/actions/runs/31193252427
Out-of-org consumer impact: N/A — GitHub code search found no ublue-os/* references to reusable-execute-release.yml; build workflows and composite actions are unchanged.

  • Opened a draft consumer PR using the documented @v1 contract
  • Linked a passing consumer CI run that exercised this branch before merge; fork refs cannot safely receive inherited release secrets, so live release-gate validation remains a maintainer step
  • Evaluated out-of-org consumers and documented the impact above

Checklist

  • I am using an agent and I take responsibility for this PR
  • Conventional commit message
  • No hardcoded secrets or credentials

Refs projectbluefin/bluefin#929

Use the testsuite managed tag for the nested release gate workflow so workflow-level fixes reach stable promotion, and prevent Renovate from restoring the stale digest pin.

Refs projectbluefin/bluefin#929

Assisted-by: GPT-5.6 Sol via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant