[quality] add regression coverage for _section_footer in render_pr_body - #412
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
[quality] add regression coverage for _section_footer in render_pr_body#412kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
_section_footer() has zero test coverage in test_render_pr_body.py. Both the action copy (.github/actions/render-pr-body/render_pr_body.py) and the script copy (scripts/render_pr_body.py) are exercised via the existing TEST_MODULES parametrize pattern. New tests verify: - separator (---) present in footer - maintainers group reference present - gh pr merge command present - --admin flag present - --repo flag included when repo arg is non-empty - --repo flag absent when repo arg is empty or default - <pr-number> placeholder present - approval count (2) mentioned - full main() render includes footer with correct --repo flag Closes #364 Signed-off-by: quality-bot <quality-bot@projectbluefin.hive>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds 20 new tests (10 parametrized for action + script copies) covering
_section_footer()inrender_pr_body.py, which had zero test coverage.Coverage added
@projectbluefin/maintainers) presentgh pr mergecommand present--adminflag present--repoflag included when repo arg is non-empty--repoflag absent when repo arg is empty or default<pr-number>placeholder presentmain()render includes footer with correct--repoflagBoth the action copy and the script copy are exercised via the existing
TEST_MODULES = [render_pr_body, SCRIPT_RENDER_PR_BODY]parametrize pattern.All 70 tests pass locally.
Related Issue
Fixes #364
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.59