Repository navigation
Conversation
With ConnectionPoolThreads > 1, NewWithOptions built a UDP pool for every base resolver, whatever its type. It read a DoH resolver's URL as host:port, so NewWithOptions failed, either splitting a URL that has a port or dialing the bogus address it got from one that doesn't. TCP and DoT resolvers got pools that no query ever used. Pool construction decided on its own which resolvers get a pool, while exchange uses one only when clientFor picks udpClient. Build pools for exactly the resolvers that clientFor sends through udpClient, so the two decisions can't drift apart again. That rule already covers Proxy, under which clientFor sends UDP resolvers over TCP. Fixes: #314 Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Oct 25, 2026
Mzack9999
deleted the
dwisiswant0/fix/client/build-connection-pools-only-for-udp-resolvers
branch
October 25, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ConnectionPoolThreads > 1, NewWithOptions built a UDP pool for
every base resolver, whatever its type. It read a DoH resolver's URL
as host:port, so NewWithOptions failed, either splitting a URL that
has a port or dialing the bogus address it got from one that
doesn't. TCP and DoT resolvers got pools that no query ever used.
Pool construction decided on its own which resolvers get a pool,
while exchange uses one only when clientFor picks udpClient. Build
pools for exactly the resolvers that clientFor sends through
udpClient, so the two decisions can't drift apart again. That rule
already covers Proxy, under which clientFor sends UDP resolvers over
TCP.
Fixes: #314