Repository navigation
fix(client): follow referrals in Trace - #331
Merged
Merged
Conversation
Trace never got past the root servers. A root server answers with a referral: an empty answer section, the next name servers in the authority section and usually their addresses (glue) in the additional section. Trace looked for name servers in the parsed NS field, which holds only answer records since 2d40354 (#279), so it found none to follow, and each step of the trace listed none. Read the referral from the reply itself. Each step's NS again lists the name servers that its reply referred to, as before 2d40354, while the glue stays out of A, the leak #279 was about. Trace reaches a name server through its glue and looks up only the names without any, once per step instead of once per reply, since every root server returns the same referral. Fixes: #310 Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Oct 25, 2026
Mzack9999
deleted the
dwisiswant0/fix/client/follow-referrals-in-trace
branch
October 25, 2026 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace never got past the root servers. A root server answers with a
referral: an empty answer section, the next name servers in the
authority section and usually their addresses (glue) in the
additional section. Trace looked for name servers in the parsed NS
field, which holds only answer records since 2d40354 (#279), so it
found none to follow, and each step of the trace listed none.
Read the referral from the reply itself. Each step's NS again lists
the name servers that its reply referred to, as before 2d40354, while
the glue stays out of A, the leak #279 was about. Trace reaches a
name server through its glue and looks up only the names without
any, once per step instead of once per reply, since every root
server returns the same referral.
Fixes: #310