Skip to content

Use unsigned arithmetic for uint division #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snazy merged 1 commit into from
Jul 17, 2026
Merged

Use unsigned arithmetic for uint division #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/projectnessie/cel/common/types/UintT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public Val divide(Val other) {
if (otherInt == 0L) {
return divideByZero();
}
return uintOf(i / otherInt);
return uintOf(Long.divideUnsigned(i, otherInt));
}

/** Modulo implements traits.Modder.Modulo. */
Expand All @@ -262,7 +262,7 @@ public Val modulo(Val other) {
if (otherInt == 0L) {
return modulusByZero();
}
return uintOf(i % otherInt);
return uintOf(Long.remainderUnsigned(i, otherInt));
}

/** Multiply implements traits.Multiplier.Multiply. */
Expand Down
7 changes: 7 additions & 0 deletions core/src/test/java/org/projectnessie/cel/common/types/UintTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ void uintConvertToType() {
@Test
void uintDivide() {
assertThat(uintOf(3).divide(uintOf(2)).equal(uintOf(1))).isSameAs(True);
assertThat(uintOf(-1L).divide(uintOf(2)).equal(uintOf(Long.MAX_VALUE))).isSameAs(True);
assertThat(uintOf(-1L).divide(uintOf(Long.MIN_VALUE)).equal(uintOf(1))).isSameAs(True);
assertThat(uintOf(Long.MIN_VALUE).divide(uintOf(2)).equal(uintOf(1L << 62))).isSameAs(True);
assertThat(UintZero.divide(UintZero))
.isInstanceOf(Err.class)
.extracting(Object::toString)
Expand Down Expand Up @@ -196,6 +199,10 @@ void uintEqual() {
@Test
void uintModulo() {
assertThat(uintOf(21).modulo(uintOf(2)).equal(uintOf(1))).isSameAs(True);
assertThat(uintOf(-1L).modulo(uintOf(2)).equal(uintOf(1))).isSameAs(True);
assertThat(uintOf(-1L).modulo(uintOf(Long.MIN_VALUE)).equal(uintOf(Long.MAX_VALUE)))
.isSameAs(True);
assertThat(uintOf(Long.MIN_VALUE).modulo(uintOf(3)).equal(uintOf(2))).isSameAs(True);
assertThat(uintOf(21).modulo(UintZero))
.isInstanceOf(Err.class)
.extracting(Object::toString)
Expand Down
Loading