Make protobuf runtime selection explicit#904
Merged
Merged
Conversation
cel-core exposed cel-generated-pb transitively even though consumers may need the protobuf 3 generated classes instead. That made cel-core plus cel-generated-pb3 resolve two providers for the same generated CEL protobuf classes. Stop publishing a generated protobuf flavor from core-level artifacts, require consumers and repo modules to choose one explicitly, and cover both choices in the build-tool integration sample. The standalone jar must include relocated generated CEL protobuf classes because its public API references those relocated types and standalone consumers may use it non-transitively. Build the shadow jar from compileClasspath so compile-only generated protobuf and protobuf runtime inputs are included without pulling Jackson runtime dependencies into the standalone artifact.
XN137
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cel-core exposed cel-generated-pb transitively even though consumers may need the protobuf 3 generated classes instead. That made cel-core plus cel-generated-pb3 resolve two providers for the same generated CEL protobuf classes.
Stop publishing a generated protobuf flavor from core-level artifacts, require consumers and repo modules to choose one explicitly, and cover both choices in the build-tool integration sample.
The standalone jar must include relocated generated CEL protobuf classes because its public API references those relocated types and standalone consumers may use it non-transitively.
Build the shadow jar from compileClasspath so compile-only generated protobuf and protobuf runtime inputs are included without pulling Jackson runtime dependencies into the standalone artifact.