Derive Jackson enum values from enum classes#918
Merged
Conversation
Jackson2 enum registration depended on the selected Jackson serializer and could fail when annotations selected a custom serializer. Derive enum values directly from the raw enum class, matching the Jackson3 path, and cover a custom-serialized enum.
XN137
approved these changes
Jul 17, 2026
| @Test | ||
| void customSerializedEnumRegistrationUsesEnumConstants() { | ||
| JacksonRegistry reg = (JacksonRegistry) newRegistry(); | ||
| reg.enumDescription(CustomSerializedEnum.class); |
Contributor
There was a problem hiding this comment.
nit: at surface level the test looks similar to the EnumWithConstantBody above, just wondering if there is any conversion roundtrip we could do to make the usage of the custom serializer "more obvious" in the test ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson2 enum registration depended on the selected Jackson serializer and could fail when annotations selected a custom serializer.
Derive enum values directly from the raw enum class, matching the Jackson3 path, and cover a custom-serialized enum.