Skip to content

[codex] refactor image view mark to wrap uri#162

Draft
ocavue wants to merge 4 commits into
masterfrom
image-view-wrap-link-uri_codex
Draft

[codex] refactor image view mark to wrap uri#162
ocavue wants to merge 4 commits into
masterfrom
image-view-wrap-link-uri_codex

Conversation

@ocavue

@ocavue ocavue commented Jun 27, 2026

Copy link
Copy Markdown
Member

Refactors inline image parsing so mdImageView wraps the parsed mdLinkUri range instead of the closing source character. This keeps the image source range intact for hiding, copy, navigation, and click lookup while placing the preview at the URI. Validated with focused image and mark-mode browser tests, full pnpm test, pnpm typecheck, and pnpm lint.

@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
meowdown Ignored Ignored Preview Jun 27, 2026 12:38pm

@pkg-pr-new

pkg-pr-new Bot commented Jun 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/prosekit/meowdown/@meowdown/core@162
npm i https://pkg.pr.new/prosekit/meowdown/@meowdown/react@162

commit: 368fd38

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 93.91% 2159 / 2299
🔵 Statements 91.76% 2375 / 2588
🔵 Functions 93.44% 542 / 580
🔵 Branches 83.81% 1326 / 1582
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/style.css 0% 0% 0% 0%
packages/core/src/extensions/image.ts 90.12% 83.33% 85.71% 91.54% 104, 110, 115, 131-132, 134, 154-155
packages/core/src/extensions/inline-marks.ts 91.17% 0% 93.75% 91.17% 97-98, 183
packages/core/src/extensions/inline-text-to-mark-chunks.ts 96.52% 92.59% 100% 96.32% 83, 228, 291, 337, 349
Generated in workflow #701 for commit 368fd38 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant