feat: render file links as inline pills#202
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
resolveFileLink and defineFileView# Conflicts: # packages/core/src/extensions/extension.ts # packages/core/src/index.ts # packages/react/src/components/editor-extensions.tsx
Member
Author
|
Merged latest master. The merge also integrates #196: |
# Conflicts: # website/src/app.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host can now claim
[label](url)links as files (resolveFileLink, read at editor creation) and render each claimed link as an inline pill: a file-kind icon, the name, and the size resolved (possibly async) byresolveFileInfo, with clicks reported through the newonFileClick. Serialization is untouched and claimed links behave like images (one caret atom, editable source). Also exportsbuildFileMarkdownso host commands that insert file links produce byte-identical markdown to a paste/drop.