Skip to content

Map2disc convergence investigation#554

Draft
jurasic-pf wants to merge 1 commit into
mainfrom
map2disc-investigation
Draft

Map2disc convergence investigation#554
jurasic-pf wants to merge 1 commit into
mainfrom
map2disc-investigation

Conversation

@jurasic-pf

@jurasic-pf jurasic-pf commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Two preliminary learnings:

  1. The initial force residual may be lower than with the default linear interpolation method, and yet converge slower. Is spectral content the culprit? (e.g. green trace)
  2. Some traces DID NOT CONVERGE with the new initialization method at all (purple, ns=25)
convergence_comparison_map2disc

with ns = 99 for the QUASR surfaces:

convergence_comparison_map2disc.png

among the QUASR configurations there's both cases that became slower and faster.

Copy link
Copy Markdown
Collaborator Author

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 88f7675 Previous: c945b86 Ratio
benchmarks/test_benchmarks.py::test_bench_fixed_boundary_cma 0.35942597935788234 iter/sec (stddev: 0.017826937794021246) 0.5799657456378193 iter/sec (stddev: 0.005199252627296805) 1.61

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant