Repository navigation
Conversation
spaceone
force-pushed
the
refactor/codec-ber-type-annotations
branch
2 times, most recently
from
October 21, 2026 22:38
8b7e55d to
675108b
Compare
spaceone
force-pushed
the
refactor/codec-ber-type-annotations
branch
from
October 21, 2026 22:38
675108b to
6496d21
Compare
Author
|
See also python/typeshed#16589 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python-ldaprecently added type annotations. To supportmypyit added a lot of type-ignore comments. They are incompatible with thety-type-checker.Example:
I want to get rid of these type-ignore comments.
I can explicitly use a
return cast(bytes, encoder.encode(self._derefSpecs())).but the long-term solution would be to just integrate it here.