Skip to content

Improved test infrastructure - #17

Merged
david-yz-liu merged 1 commit into
mainfrom
testing
Aug 8, 2026
Merged

Improved test infrastructure#17
david-yz-liu merged 1 commit into
mainfrom
testing

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This pull request improves the testing infrastructure:

  • Fixed the Python test suite (broken test mocks, a stale template placeholder test, and a file descriptor double-close causing spurious warnings) and added unit tests for previously-untested language server helpers
    • Fixed a bug where substitute_attr in bundled/tool/lsp_utils.py where the attribute wasn't restored when the inner block raised an error.
  • Added a TypeScript extension test suite (Mocha + @vscode/test-electron) covering extension activation and the common/ modules, where none existed before
  • Added a GitHub Actions workflow to run both test suites on pull requests and pushes to main
Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@david-yz-liu
david-yz-liu force-pushed the testing branch 2 times, most recently from 54fe431 to 93e08d4 Compare August 8, 2026 12:36
@david-yz-liu
david-yz-liu merged commit dbf7405 into main Aug 8, 2026
2 checks passed
@david-yz-liu
david-yz-liu deleted the testing branch August 8, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant