gh-148207: add additional keywords to typing.TypeVarTuple#148212
Open
KotlinIsland wants to merge 3 commits intopython:mainfrom
Open
gh-148207: add additional keywords to typing.TypeVarTuple#148212KotlinIsland wants to merge 3 commits intopython:mainfrom
typing.TypeVarTuple#148212KotlinIsland wants to merge 3 commits intopython:mainfrom
Conversation
KotlinIsland
force-pushed
the
tvt
branch
3 times, most recently
from
912a359 to
e2772a5
Compare
AlexWaygood
reviewed
Apr 8, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
The tests and docs look good, and the change makes sense to me. Thanks!
I'll leave a review of the C code to others who are more qualified.
sharktide
reviewed
Apr 9, 2026
Contributor
sharktide
left a comment
sharktide
left a comment
There was a problem hiding this comment.
Agreed; the changes and implementation make sense, but I’ll leave this to someone more qualified
KotlinIsland
changed the title
typing.TypeVarTuple
JelleZijlstra
approved these changes
Apr 16, 2026
JelleZijlstra
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 265233d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148212%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Member
|
I think this is ready but CI is having some random failures, I'll wait a bit and see if I need to poke it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeVarTuple#148207📚 Documentation preview 📚: https://cpython-previews--148212.org.readthedocs.build/